Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TimeInput not triggering onChange on incomplete values #1711

Merged
merged 3 commits into from
Jan 11, 2024

Fix overlapping act() calls warning in unit tests

8295b5a
Select commit
Loading
Failed to load commit list.
Merged

fix: TimeInput not triggering onChange on incomplete values #1711

Fix overlapping act() calls warning in unit tests
8295b5a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 5, 2024 in 0s

46.46% (+0.01%) compared to 73e1837

View this Pull Request on Codecov

46.46% (+0.01%) compared to 73e1837

Details

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (73e1837) 46.44% compared to head (8295b5a) 46.46%.

Files Patch % Lines
packages/components/src/TimeInput.tsx 94.73% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1711      +/-   ##
==========================================
+ Coverage   46.44%   46.46%   +0.01%     
==========================================
  Files         611      611              
  Lines       37204    37217      +13     
  Branches     9363     9365       +2     
==========================================
+ Hits        17279    17292      +13     
  Misses      19871    19871              
  Partials       54       54

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov