-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Reject promise immediately if var not found #1718
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1718 +/- ##
=======================================
Coverage 46.44% 46.44%
=======================================
Files 611 611
Lines 37204 37206 +2
Branches 9363 9364 +1
=======================================
+ Hits 17279 17281 +2
Misses 19871 19871
Partials 54 54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just a minor correction to the error message.
Co-authored-by: Mike Bender <mikebender@deephaven.io>
fetchVariableDefinition
now throws anError
when a variable is not found (instead of throwingTimeoutError
)TimeoutError
still used and will be thrown on an actual timeout