Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Reject promise immediately if var not found #1718

Merged
merged 4 commits into from
Jan 11, 2024
Merged

feat: Reject promise immediately if var not found #1718

merged 4 commits into from
Jan 11, 2024

Conversation

wusteven815
Copy link
Contributor

@wusteven815 wusteven815 commented Jan 8, 2024

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (73e1837) 46.44% compared to head (1a2626a) 46.44%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1718   +/-   ##
=======================================
  Coverage   46.44%   46.44%           
=======================================
  Files         611      611           
  Lines       37204    37206    +2     
  Branches     9363     9364    +1     
=======================================
+ Hits        17279    17281    +2     
  Misses      19871    19871           
  Partials       54       54           
Flag Coverage Δ
unit 46.44% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a minor correction to the error message.

packages/jsapi-utils/src/ConnectionUtils.ts Outdated Show resolved Hide resolved
Co-authored-by: Mike Bender <mikebender@deephaven.io>
@wusteven815 wusteven815 merged commit 43d40bd into deephaven:main Jan 11, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 11, 2024
@wusteven815 wusteven815 deleted the feat-1701 branch January 17, 2024 14:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reject promise immediately if variable is not in first message of field updates
2 participants