Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: theming tweaks #1727

Merged
merged 40 commits into from
Jan 16, 2024
Merged

feat: theming tweaks #1727

merged 40 commits into from
Jan 16, 2024

Conversation

dsmmcken
Copy link
Contributor

Miscellaneous light and dark theme tweaks after using it for awhile. Mostly things that were either improperly styled or issues for enterprise.

  • light disabled color for secondary buttons
  • adjust subdued-content-bg defninition
  • adjusted dark surface color
  • tweaked light theme to be grayer
  • added subdued-content-bg variable
  • fix button alignment
  • style tweaks
  • minor color fixes
  • style editor in conditional formating style fixes
  • fix console button disabled object styling
  • Numerous color adjustments
  • fix malformed hsl variable
  • adjust time slider styling
  • fix HCM styling
  • fix styling of custom time select
  • item-list styling
  • add fallback colors for a few more things, so that error message before api works
  • Buttons can use gap instead of margin on icons now that they are flex. Much easier.
  • whitespace change
  • expose is modified styling to styleguide timeslider for checking
  • styleguide icon button styling
  • add some spectrum stuff to styleguide for easier comparison
  • purge primary-light
  • schotcut settings rror message styling
  • settings menu user image and logo button adjust
  • widget list hover color
  • add legend color

@dsmmcken dsmmcken requested review from bmingles and mofojed January 12, 2024 16:52
Copy link
Contributor

@bmingles bmingles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good overall.

  • 1 minor suggestion for a comment tweak
  • Also 2 styleguide alignment things I noticed with spectrum-forms and spectrum comparison checkbox / radio examples

Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6894d96) 46.46% compared to head (6262177) 46.48%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1727      +/-   ##
==========================================
+ Coverage   46.46%   46.48%   +0.02%     
==========================================
  Files         617      617              
  Lines       37292    37288       -4     
  Branches     9378     9376       -2     
==========================================
+ Hits        17327    17335       +8     
+ Misses      19911    19899      -12     
  Partials       54       54              
Flag Coverage Δ
unit 46.48% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dsmmcken dsmmcken requested a review from bmingles January 15, 2024 21:05
bmingles
bmingles previously approved these changes Jan 16, 2024
Copy link
Contributor

@bmingles bmingles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsmmcken dsmmcken linked an issue Jan 16, 2024 that may be closed by this pull request
mofojed
mofojed previously approved these changes Jan 16, 2024
@dsmmcken dsmmcken dismissed stale reviews from mofojed and bmingles via 54126f7 January 16, 2024 17:45
@dsmmcken dsmmcken requested review from bmingles and mofojed January 16, 2024 17:48
@dsmmcken dsmmcken merged commit f919a7e into main Jan 16, 2024
5 checks passed
@dsmmcken dsmmcken deleted the dmckenzie_light_theme_fixes branch January 16, 2024 19:49
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HR elements are not visible
3 participants