-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: theming tweaks #1727
feat: theming tweaks #1727
Conversation
packages/components/src/theme/theme-spectrum/theme-spectrum-overrides.css
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good overall.
- 1 minor suggestion for a comment tweak
- Also 2 styleguide alignment things I noticed with spectrum-forms and spectrum comparison checkbox / radio examples
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1727 +/- ##
==========================================
+ Coverage 46.46% 46.48% +0.02%
==========================================
Files 617 617
Lines 37292 37288 -4
Branches 9378 9376 -2
==========================================
+ Hits 17327 17335 +8
+ Misses 19911 19899 -12
Partials 54 54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Miscellaneous light and dark theme tweaks after using it for awhile. Mostly things that were either improperly styled or issues for enterprise.