Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds icons dhUnderline and dhStrikethrough #1732

Merged
merged 2 commits into from
Jan 18, 2024

Conversation

dsmmcken
Copy link
Contributor

Adds dhUnderline and dhStrikethrough icons matching vsBold and vsItalic.

image

Required for #1715 conditional formatting UI.

@dsmmcken dsmmcken requested a review from mofojed January 17, 2024 20:47
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (629ed23) 46.48% compared to head (244057a) 46.48%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1732   +/-   ##
=======================================
  Coverage   46.48%   46.48%           
=======================================
  Files         617      617           
  Lines       37289    37289           
  Branches     9378     9378           
=======================================
  Hits        17335    17335           
  Misses      19900    19900           
  Partials       54       54           
Flag Coverage Δ
unit 46.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dsmmcken dsmmcken merged commit c6a099d into main Jan 18, 2024
5 checks passed
@dsmmcken dsmmcken deleted the dmckenzie_icons_underline_strikethrough branch January 18, 2024 14:34
@github-actions github-actions bot locked and limited conversation to collaborators Jan 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants