fix: show copy cursor in grid on key down and not just mouse move #1735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds copy cell keyhandler to set cursor on keydown. Grid was only showing copy cursor on mouse move, not just key down. Unfortanetly we still require focus to get the keydown, and I don't think it's worth hacking around that. - Moved cursor styles to base style sheet, so that it is shared to DHE - Moved cursors and logos in to asset folder (folders named "asssets" are bundled by vite - Tweaked copy icon svg (aliasing is improved) - default cursor to "copy" in iris grid so that it shows in embed widget too Breaking change: Cursors classes have additional specifity under #root id, DHE classes containing linker and copy cursors can be removed
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1735 +/- ##
==========================================
- Coverage 46.48% 46.48% -0.01%
==========================================
Files 617 618 +1
Lines 37289 37316 +27
Branches 9378 9386 +8
==========================================
+ Hits 17335 17347 +12
- Misses 19900 19915 +15
Partials 54 54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Test on Enterprise with start-community |
|
Confirmed it works with start-community |
mofojed
approved these changes
Feb 2, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: linker and iris grid custom cursor styling and assets are now provided by components directly. DHE css and svg files containing linker cursors should be removed/de-duplicated.