Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added section support to Picker #1847

Merged
merged 17 commits into from
Mar 4, 2024

Conversation

bmingles
Copy link
Contributor

@bmingles bmingles commented Feb 29, 2024

  • Picker component now supports
    children
  • Re-exported Spectrum Item + Section components

Supports deephaven/deephaven-plugins/issues/292

@bmingles bmingles changed the title feat: Added section support to Picker (#plugins-292) feat: Added section support to Picker Feb 29, 2024
@bmingles bmingles force-pushed the plugins-292-picker-sections branch from c44619e to f00d1db Compare March 1, 2024 15:49
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 46.07%. Comparing base (8892074) to head (d04b0cf).
Report is 2 commits behind head on main.

Files Patch % Lines
packages/components/src/spectrum/picker/Picker.tsx 0.00% 10 Missing ⚠️
...mponents/src/spectrum/picker/PickerItemContent.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1847      +/-   ##
==========================================
+ Coverage   46.03%   46.07%   +0.03%     
==========================================
  Files         635      635              
  Lines       37935    37978      +43     
  Branches     9563     9586      +23     
==========================================
+ Hits        17465    17499      +34     
- Misses      20416    20425       +9     
  Partials       54       54              
Flag Coverage Δ
unit 46.07% <80.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmingles bmingles marked this pull request as ready for review March 1, 2024 17:30
@bmingles bmingles requested a review from mofojed March 1, 2024 18:46
@bmingles bmingles requested a review from mofojed March 4, 2024 16:28
@bmingles bmingles merged commit 1381ee7 into deephaven:main Mar 4, 2024
5 checks passed
@bmingles bmingles deleted the plugins-292-picker-sections branch March 4, 2024 18:58
@github-actions github-actions bot locked and limited conversation to collaborators Mar 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui.picker Implementation with constant data provided from server
2 participants