Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new chart error panel #1850

Merged
merged 10 commits into from
Apr 5, 2024
Merged

Conversation

ethanalvizo
Copy link
Contributor

Closes #1520

@ethanalvizo ethanalvizo self-assigned this Mar 5, 2024
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 46.24%. Comparing base (ffedd7a) to head (1d4dd69).
Report is 5 commits behind head on main.

Files Patch % Lines
packages/chart/src/Chart.tsx 0.00% 13 Missing ⚠️
packages/chart/src/ChartErrorOverlay.tsx 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1850      +/-   ##
==========================================
- Coverage   46.26%   46.24%   -0.03%     
==========================================
  Files         646      647       +1     
  Lines       38252    38269      +17     
  Branches     9673     9681       +8     
==========================================
  Hits        17697    17697              
- Misses      20502    20519      +17     
  Partials       53       53              
Flag Coverage Δ
unit 46.24% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ethanalvizo ethanalvizo marked this pull request as ready for review March 5, 2024 07:46
@ethanalvizo ethanalvizo requested a review from mofojed March 5, 2024 07:46
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has strange behaviour when running the snippet from #1520 (comment)

  1. Plot appears with message "Disable downsampling to retrieve all items" and a "Continue" button.
  2. I click Continue, then nothing appears in the plot.

I would assume that clicking Continue in that case with that message would mean the plot would try to load, loading spinner etc. but that doesn't appear to be the case. Why aren't we trying to load it?

packages/chart/src/Chart.tsx Outdated Show resolved Hide resolved
packages/chart/src/ChartErrorOverlay.tsx Outdated Show resolved Hide resolved
@ethanalvizo
Copy link
Contributor Author

image

New error popup^

@ethanalvizo ethanalvizo requested a review from mofojed March 26, 2024 20:17
packages/chart/src/ChartErrorOverlay.tsx Outdated Show resolved Hide resolved
packages/chart/src/ChartErrorOverlay.tsx Outdated Show resolved Hide resolved
packages/chart/src/ChartErrorOverlay.tsx Outdated Show resolved Hide resolved
mofojed
mofojed previously approved these changes Mar 27, 2024
@mofojed mofojed enabled auto-merge (squash) March 27, 2024 13:46
@mofojed mofojed merged commit 309ff79 into deephaven:main Apr 5, 2024
5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Downsampling is automatically applied to charts that don't support it
2 participants