Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: swap goto tooltips #1860

Merged
merged 1 commit into from
Mar 12, 2024
Merged

fix: swap goto tooltips #1860

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/iris-grid/src/GotoRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,7 +386,7 @@ const GotoRow = forwardRef<GotoRowElement, GotoRowProps>(

<div>
<Button
tooltip="Next match"
tooltip="Previous match"
icon={vsArrowUp}
kind="ghost"
disabled={gotoValue === ''}
Expand All @@ -395,7 +395,7 @@ const GotoRow = forwardRef<GotoRowElement, GotoRowProps>(
}}
/>
<Button
tooltip="Previous match"
tooltip="Next match"
icon={vsArrowDown}
kind="ghost"
disabled={gotoValue === ''}
Expand Down
6 changes: 3 additions & 3 deletions tests/context-menu.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,13 +219,13 @@ test('go to', async ({ page }) => {
await waitForLoadingDone(page);
await expect(page.locator('.iris-grid-column')).toHaveScreenshot();

await page.locator('[aria-label="Previous match"]').first().click();
await page.locator('[aria-label="Previous match"]').first().click();
await page.locator('[aria-label="Next match"]').first().click();
await page.locator('[aria-label="Next match"]').first().click();

await waitForLoadingDone(page);
await expect(page.locator('.iris-grid-column')).toHaveScreenshot();

await page.locator('[aria-label="Next match"]').first().click();
await page.locator('[aria-label="Previous match"]').first().click();

await waitForLoadingDone(page);
await expect(page.locator('.iris-grid-column')).toHaveScreenshot();
Expand Down
Loading