Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace code studio home icon with "Code Studio" as label #1951

Merged
merged 3 commits into from
Apr 20, 2024

Conversation

dsmmcken
Copy link
Contributor

@dsmmcken dsmmcken commented Apr 19, 2024

Fixes #1794

  • Label home as "vsTerminal Code Studio"
  • Make it part of the navtab list to get an active state
  • Allow navtab list to accept an Icon | JSX.Element

- Label home as "vsTerminal Code Studio"
- Make it part of the navtab list to get an active state
- Allow navtab list to accept an Icon | JSX.Element
@dsmmcken dsmmcken requested a review from mattrunyon April 19, 2024 20:22
@dsmmcken dsmmcken self-assigned this Apr 19, 2024
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

Attention: Patch coverage is 7.69231% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 46.26%. Comparing base (9e9e272) to head (8dce5a9).

Files Patch % Lines
packages/code-studio/src/main/AppMainContainer.tsx 12.50% 7 Missing ⚠️
packages/components/src/navigation/NavTab.tsx 0.00% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1951      +/-   ##
==========================================
- Coverage   46.26%   46.26%   -0.01%     
==========================================
  Files         656      656              
  Lines       38455    38460       +5     
  Branches     9725     9730       +5     
==========================================
  Hits        17792    17792              
- Misses      20610    20615       +5     
  Partials       53       53              
Flag Coverage Δ
unit 46.26% <7.69%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dsmmcken dsmmcken enabled auto-merge (squash) April 19, 2024 21:55
@dsmmcken dsmmcken merged commit 111ea64 into main Apr 20, 2024
5 checks passed
@dsmmcken dsmmcken deleted the dmckenzie_code_studio_home branch April 20, 2024 00:17
@github-actions github-actions bot locked and limited conversation to collaborators Apr 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Home button needs left margin
2 participants