-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Replace shortid package with nanoid package #2025
fix: Replace shortid package with nanoid package #2025
Conversation
Looking into errors here |
Remove In transform: [
['babelify', { presets: ['@babel/preset-env'], global: true }],
], This seems to fix the issue by using babel to transpile the ESM before the bundling for the test. |
LGTM. Will wait for @mattrunyon to approve since he suggested the babelify change, and I'm less familiar here |
Sounds good, thanks @bmingles |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a @types/shortid
in the root package.json
still. Remove it and run npm install
again so it's removed from package-lock too.
Weird, I remember removing it? Although, I was having some issues when I was switching branches with the differences with my package.json so I clean installed a couple of times on different branches , something may have gotten messed up. Will fix this shortly and repush @mattrunyon |
Resolves #1922
Changes Implemented:
Info on Nanoid: https://github.com/ai/nanoid/blob/main/README.md