Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Console scroll bar following dynamic output #2076

Merged
merged 7 commits into from
Jun 14, 2024
Merged

fix: Console scroll bar following dynamic output #2076

merged 7 commits into from
Jun 14, 2024

Conversation

AkshatJawne
Copy link
Contributor

Resolves #2060

Changes Implemented:

  • Added isStuckToBottom state that is updated on each scroll (in handleScrollPaneScroll), then in componentDidUpdate, call the scrollConsoleHistoryToBottom based on isStuckToBottom

@AkshatJawne AkshatJawne self-assigned this Jun 13, 2024
mattrunyon
mattrunyon requested changes Jun 13, 2024
View reviewed changes
packages/console/src/Console.tsx Outdated Show resolved Hide resolved
packages/console/src/Console.tsx Show resolved Hide resolved
packages/console/src/Console.tsx Outdated Show resolved Hide resolved
@AkshatJawne AkshatJawne requested a review from mattrunyon June 14, 2024 15:05
@AkshatJawne AkshatJawne merged commit a91e4f3 into deephaven:main Jun 14, 2024
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattrunyon mattrunyon mattrunyon approved these changes

@mofojed mofojed Awaiting requested review from mofojed

Assignees

@AkshatJawne AkshatJawne

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Console scroll bar won't follow dynamic output
2 participants
@AkshatJawne @mattrunyon