Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: re-export remaining types needed by dh ui from @react-types/shared #2132

Conversation

AkshatJawne
Copy link
Contributor

Resolves #2084

Steps Moving Forward:

  • Once this PR has merged, will go into plugins repo and use the re-exported types, and remove @react-types/shared dependency (in order to further eliminate spectrum dependency)

@AkshatJawne AkshatJawne requested a review from bmingles July 8, 2024 15:01
@AkshatJawne AkshatJawne self-assigned this Jul 8, 2024
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.59%. Comparing base (115e057) to head (63e8607).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #2132    +/-   ##
========================================
  Coverage   46.59%   46.59%            
========================================
  Files         681      682     +1     
  Lines       38430    38441    +11     
  Branches     9576     9764   +188     
========================================
+ Hits        17905    17912     +7     
- Misses      20515    20519     +4     
  Partials       10       10            
Flag Coverage Δ
unit 46.59% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bmingles bmingles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AkshatJawne AkshatJawne merged commit 2119a61 into deephaven:main Jul 8, 2024
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

re-export @react-types/shared types needed by dh ui
2 participants