Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Pass through additional actions from WidgetPanel #2224

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

mofojed
Copy link
Member

@mofojed mofojed commented Sep 16, 2024

  • additionalActions was only a prop on Panel
  • Add it as a prop on WidgetPanel and pass it through

- additionalActions was only a prop on Panel
- Add it as a prop on WidgetPanel and pass it through
@mofojed mofojed requested a review from vbabich September 16, 2024 21:13
@mofojed mofojed self-assigned this Sep 16, 2024
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 46.78%. Comparing base (1503a37) to head (e146d8d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../dashboard-core-plugins/src/panels/WidgetPanel.tsx 75.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2224   +/-   ##
=======================================
  Coverage   46.77%   46.78%           
=======================================
  Files         694      694           
  Lines       38625    38624    -1     
  Branches     9867     9868    +1     
=======================================
+ Hits        18068    18070    +2     
+ Misses      20504    20501    -3     
  Partials       53       53           
Flag Coverage Δ
unit 46.78% <80.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mofojed mofojed merged commit bc720d1 into deephaven:main Sep 17, 2024
12 checks passed
@mofojed mofojed deleted the widget-panel-additional-actions branch September 17, 2024 18:41
@github-actions github-actions bot locked and limited conversation to collaborators Sep 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants