Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Fix e2e tests for builds on v0.85 #2316

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

mofojed
Copy link
Member

@mofojed mofojed commented Dec 13, 2024

  • The edge version of deephaven-core installs the latest version of deephaven.ui, which is not compatible with this old version of the UI
  • Just pin the e2e tests to an older build of core

- The edge version of deephaven-core installs the latest version of deephaven.ui, which is not compatible with this old version of the UI
- Just pin the e2e tests to an older build of core
@mofojed mofojed requested a review from vbabich December 13, 2024 21:10
@mofojed mofojed self-assigned this Dec 13, 2024
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.65%. Comparing base (552f4d7) to head (a57bcd2).

Additional details and impacted files
@@              Coverage Diff               @@
##           release/v0.85    #2316   +/-   ##
==============================================
  Coverage          46.65%   46.65%           
==============================================
  Files                685      685           
  Lines              38495    38495           
  Branches            9590     9590           
==============================================
  Hits               17961    17961           
  Misses             20524    20524           
  Partials              10       10           
Flag Coverage Δ
unit 46.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mofojed mofojed merged commit c44deae into deephaven:release/v0.85 Dec 13, 2024
11 checks passed
@mofojed mofojed deleted the fix-e2e-grizzly branch December 13, 2024 21:48
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants