-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert Console to typescript #646
Conversation
Codecov Report
@@ Coverage Diff @@
## main #646 +/- ##
==========================================
- Coverage 35.76% 35.71% -0.05%
==========================================
Files 396 397 +1
Lines 29183 29333 +150
Branches 6957 7023 +66
==========================================
+ Hits 10436 10475 +39
- Misses 18561 18710 +149
+ Partials 186 148 -38
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll have more comments after lunch, just posting my first part of the review.
packages/console/src/console-history/ConsoleHistoryResultInProgress.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Mike Bender <mikebender@deephaven.io>
Co-authored-by: Mike Bender <mikebender@deephaven.io>
Co-authored-by: Mike Bender <mikebender@deephaven.io>
Co-authored-by: Mike Bender <mikebender@deephaven.io>
Co-authored-by: Mike Bender <mikebender@deephaven.io>
Fixes #641