Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Console to typescript #646

Merged
merged 26 commits into from
Jul 21, 2022
Merged

Conversation

Zhou-Ziheng
Copy link
Contributor

Fixes #641

@Zhou-Ziheng Zhou-Ziheng added the enhancement New feature or request label Jul 11, 2022
@Zhou-Ziheng Zhou-Ziheng requested a review from mofojed July 11, 2022 21:02
@Zhou-Ziheng Zhou-Ziheng self-assigned this Jul 11, 2022
@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #646 (15be02e) into main (a3f37ab) will decrease coverage by 0.04%.
The diff coverage is 23.63%.

@@            Coverage Diff             @@
##             main     #646      +/-   ##
==========================================
- Coverage   35.76%   35.71%   -0.05%     
==========================================
  Files         396      397       +1     
  Lines       29183    29333     +150     
  Branches     6957     7023      +66     
==========================================
+ Hits        10436    10475      +39     
- Misses      18561    18710     +149     
+ Partials      186      148      -38     
Flag Coverage Δ
unit 35.71% <23.63%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/components/src/shortcuts/Shortcut.ts 59.15% <ø> (ø)
packages/console/src/ConsoleInput.tsx 0.00% <0.00%> (ø)
packages/console/src/ConsolePropTypes.ts 0.00% <ø> (ø)
packages/console/src/StoragePropTypes.ts 0.00% <ø> (ø)
packages/console/src/common/Code.tsx 0.00% <0.00%> (ø)
packages/console/src/csv/NewTableColumnTypes.ts 100.00% <ø> (ø)
packages/console/src/log/LogLevelMenuItem.tsx 0.00% <0.00%> (ø)
packages/console/src/log/LogView.tsx 0.00% <0.00%> (ø)
packages/console/src/notebook/Editor.tsx 0.00% <0.00%> (ø)
packages/console/src/notebook/ScriptEditor.tsx 0.00% <0.00%> (ø)
... and 54 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3f37ab...15be02e. Read the comment docs.

@Zhou-Ziheng Zhou-Ziheng requested a review from mattrunyon July 12, 2022 16:30
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll have more comments after lunch, just posting my first part of the review.

package.json Show resolved Hide resolved
packages/console/src/Console.tsx Outdated Show resolved Hide resolved
packages/console/src/Console.tsx Outdated Show resolved Hide resolved
packages/console/src/Console.tsx Outdated Show resolved Hide resolved
packages/console/src/Console.tsx Outdated Show resolved Hide resolved
packages/console/src/common/ConsoleUtils.ts Outdated Show resolved Hide resolved
packages/console/src/common/ConsoleUtils.ts Show resolved Hide resolved
packages/console/src/common/ConsoleUtils.ts Outdated Show resolved Hide resolved
packages/console/src/common/ConsoleUtils.ts Outdated Show resolved Hide resolved
packages/console/src/csv/CsvFormats.ts Outdated Show resolved Hide resolved
packages/console/src/csv/CsvOverlay.tsx Outdated Show resolved Hide resolved
packages/console/src/csv/CsvOverlay.tsx Outdated Show resolved Hide resolved
packages/console/src/monaco/MonacoUtils.ts Outdated Show resolved Hide resolved
packages/console/src/monaco/MonacoUtils.ts Outdated Show resolved Hide resolved
packages/console/src/monaco/MonacoUtils.ts Show resolved Hide resolved
packages/console/src/notebook/ScriptEditor.tsx Outdated Show resolved Hide resolved
packages/console/src/notebook/ScriptEditor.tsx Outdated Show resolved Hide resolved
@Zhou-Ziheng Zhou-Ziheng requested a review from mofojed July 18, 2022 20:22
packages/console/src/Console.tsx Outdated Show resolved Hide resolved
packages/console/src/Console.tsx Outdated Show resolved Hide resolved
packages/console/src/Console.tsx Outdated Show resolved Hide resolved
packages/console/src/Console.tsx Outdated Show resolved Hide resolved
packages/console/src/monaco/MonacoUtils.ts Outdated Show resolved Hide resolved
packages/console/src/monaco/lang/db.ts Outdated Show resolved Hide resolved
packages/console/src/monaco/lang/groovy.ts Outdated Show resolved Hide resolved
packages/console/src/monaco/lang/log.ts Outdated Show resolved Hide resolved
packages/console/src/monaco/lang/python.ts Outdated Show resolved Hide resolved
packages/console/src/monaco/lang/scala.ts Outdated Show resolved Hide resolved
Zhou-Ziheng and others added 6 commits July 20, 2022 14:10
Co-authored-by: Mike Bender <mikebender@deephaven.io>
Co-authored-by: Mike Bender <mikebender@deephaven.io>
Co-authored-by: Mike Bender <mikebender@deephaven.io>
Co-authored-by: Mike Bender <mikebender@deephaven.io>
Co-authored-by: Mike Bender <mikebender@deephaven.io>
@Zhou-Ziheng Zhou-Ziheng requested a review from mofojed July 21, 2022 15:16
@Zhou-Ziheng Zhou-Ziheng merged commit baeb1d7 into deephaven:main Jul 21, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert @deephaven/console package to TypeScript
2 participants