Skip to content

Commit

Permalink
led: qcom-lpg: Fix resource leaks in for_each_available_child_of_node…
Browse files Browse the repository at this point in the history
…() loops

Ensure child node references are decremented properly in the error path.

Signed-off-by: Lu Hongfei <luhongfei@vivo.com>
Link: https://lore.kernel.org/r/20230525111705.3055-1-luhongfei@vivo.com
Signed-off-by: Lee Jones <lee@kernel.org>
  • Loading branch information
Lu Hongfei authored and lag-linaro committed May 25, 2023
1 parent 28598e2 commit 8f38f8f
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions drivers/leds/rgb/leds-qcom-lpg.c
Original file line number Diff line number Diff line change
Expand Up @@ -1173,8 +1173,10 @@ static int lpg_add_led(struct lpg *lpg, struct device_node *np)
i = 0;
for_each_available_child_of_node(np, child) {
ret = lpg_parse_channel(lpg, child, &led->channels[i]);
if (ret < 0)
if (ret < 0) {
of_node_put(child);
return ret;
}

info[i].color_index = led->channels[i]->color;
info[i].intensity = 0;
Expand Down Expand Up @@ -1352,8 +1354,10 @@ static int lpg_probe(struct platform_device *pdev)

for_each_available_child_of_node(pdev->dev.of_node, np) {
ret = lpg_add_led(lpg, np);
if (ret)
if (ret) {
of_node_put(np);
return ret;
}
}

for (i = 0; i < lpg->num_channels; i++)
Expand Down

0 comments on commit 8f38f8f

Please sign in to comment.