Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Semantic Segmentation app #263

Merged
merged 2 commits into from
Oct 11, 2022

Conversation

wxm2018
Copy link
Contributor

@wxm2018 wxm2018 commented Sep 21, 2022

newly add a SelfSemanticSegmentationTranslator class to get the original photo pixels, modify the way of model loading in SemanticModel.java, and add a SwitchCompat in SemanticActivity.java

@frankfliu
Copy link
Contributor

@wxm2018
Thanks a lot for your contribution, I think the right way to improve the SemanticSegmentation is to improve the SemanticSegmentationTranslator directly. Would you mind apply your change directly to: https://github.com/deepjavalibrary/djl/blob/master/api/src/main/java/ai/djl/modality/cv/translator/SemanticSegmentationTranslator.java

@wxm2018
Copy link
Contributor Author

wxm2018 commented Sep 21, 2022

@frankfliu Ok, I will resubmit a new PR. And I discussed this with xyang. Her suggestion was to keep the original Translator. Can I add a new custom xxxTranslator.java file in the ai.djl.modality.cv.translator package?

@xyang16 xyang16 changed the title add a translator to get the original photo pixels [WIP] Update Semantic Segmentation app Sep 29, 2022
@xyang16 xyang16 changed the title [WIP] Update Semantic Segmentation app Update Semantic Segmentation app Sep 29, 2022
@xyang16 xyang16 force-pushed the add_translator branch 2 times, most recently from 65fb90c to fd8afad Compare September 29, 2022 01:45
@lanking520
Copy link
Contributor

Can current implementation crop the drawing area?

@xyang16
Copy link
Contributor

xyang16 commented Sep 29, 2022

Can current implementation crop the drawing area?

You mean only remove the background?

@lanking520
Copy link
Contributor

Like remove background and narrow to the area we need

@xyang16
Copy link
Contributor

xyang16 commented Sep 30, 2022

Like remove background and narrow to the area we need

We need to keep the whole background (to replace to other color or image)

@xyang16
Copy link
Contributor

xyang16 commented Oct 9, 2022

Update app. See the screenshot below.
Screenshot_20221009-164402-906

@xyang16 xyang16 force-pushed the add_translator branch 3 times, most recently from 3db8b11 to b4ba945 Compare October 10, 2022 18:23
@xyang16 xyang16 merged commit ce2637c into deepjavalibrary:master Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants