Fixes #999, hanlde UTF16 surrogate charactors properly. #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stu1130
approved these changes
Jun 9, 2021
| @@ -100,9 +111,22 @@ inline std::vector<std::string> GetVecFromJStringArray(JNIEnv* env, jobjectArray | |||
| // String[] | |||
| inline jobjectArray GetStringArrayFromVec(JNIEnv* env, const std::vector <std::string> &vec) { | |||
| jobjectArray array = env->NewObjectArray(vec.size(), env->FindClass("Ljava/lang/String;"), nullptr); | |||
|
|
|||
There was a problem hiding this comment.
you can put the comment here saying cache the java reflection method to get better perf.
Change-Id: I19e77cf5a8282bea901434041806eb102549ec0f
Codecov Report
@@ Coverage Diff @@
## master #1003 +/- ##
=========================================
Coverage 70.02% 70.02%
- Complexity 5105 5106 +1
=========================================
Files 504 504
Lines 22582 22582
Branches 2366 2366
=========================================
+ Hits 15812 15814 +2
+ Misses 5503 5502 -1
+ Partials 1267 1266 -1
Continue to review full report at Codecov.
|
AzizZayed
added a commit
to AzizZayed/djl
that referenced
this pull request
Jun 15, 2021
commit 0092f8e Author: Aziz Zayed <azayed01@gmail.com> Date: Tue Jun 15 08:22:51 2021 -0700 Fixed truncated-normal bug commit a6ded8c Author: Aziz Zayed <azayed01@gmail.com> Date: Mon Jun 14 13:33:30 2021 -0700 [pytorch] Add BigGAN demo commit f145614 Merge: a8a1a9b ec8405b Author: Abd-El-Aziz Zayed <48853777+AzizZayed@users.noreply.github.com> Date: Fri Jun 11 20:45:34 2021 -0700 Merge branch 'deepjavalibrary:master' into master commit ec8405b Author: Abd-El-Aziz Zayed <48853777+AzizZayed@users.noreply.github.com> Date: Fri Jun 11 14:53:59 2021 -0700 [pytorch] Add oneHot operator (deepjavalibrary#1014) [tensoflow] Add truncated normal operation commit 50600fd Author: Frank Liu <frankfliu2000@gmail.com> Date: Fri Jun 11 14:53:43 2021 -0700 upgrade dependencies version (deepjavalibrary#1012) Change-Id: I709938f69f21096bc5cd29a24191f0f282dcbc97 commit 3379fd2 Author: Frank Liu <frankfliu2000@gmail.com> Date: Fri Jun 11 14:53:29 2021 -0700 [serving] Fix flaky test (deepjavalibrary#1013) Change-Id: I13b89e04516c59a3d28ecafd49f4f808630b22fb commit 23157fd Author: Frank Liu <frankfliu2000@gmail.com> Date: Thu Jun 10 16:31:03 2021 -0700 Enable spotbugs for java 11+ (deepjavalibrary#1010) Change-Id: I74effbf45492a5cf50e09ba8af0223d2b1bcb5a5 commit 4f38708 Author: Frank Liu <frankfliu2000@gmail.com> Date: Thu Jun 10 16:30:50 2021 -0700 Fix model zoo test typo (deepjavalibrary#1009) Change-Id: I7c0109c6e5fc0ece16288082fd830718f20ad489 commit a8a1a9b Merge: 77809f4 30b03f4 Author: Aziz Zayed <azayed01@gmail.com> Date: Thu Jun 10 15:16:05 2021 -0700 Merge Truncated-Normal branch commit 77809f4 Author: Frank Liu <frankfliu2000@gmail.com> Date: Thu Jun 10 14:07:43 2021 -0700 Make model zoo test weekly (deepjavalibrary#1004) Change-Id: I1c73df17cb077b9ce8905fcc2fc8bbb37b9688d8 commit 0aec8ca Author: Abd-El-Aziz Zayed <48853777+AzizZayed@users.noreply.github.com> Date: Thu Jun 10 12:46:16 2021 -0700 [tensoflow] Add truncated normal operation (deepjavalibrary#1005) commit 30b03f4 Author: Aziz Zayed <azayed01@gmail.com> Date: Wed Jun 9 01:40:33 2021 -0700 [tensoflow] Add truncated normal operation commit d8e7e1d Author: Frank Liu <frankfliu2000@gmail.com> Date: Wed Jun 9 07:55:15 2021 -0700 Fixes deepjavalibrary#999, hanlde UTF16 surrogate charactors properly. (deepjavalibrary#1003) Change-Id: I19e77cf5a8282bea901434041806eb102549ec0f commit b0fe73a Author: Frank Liu <frankfliu2000@gmail.com> Date: Tue Jun 8 17:56:19 2021 -0700 [pytorch] Update load model jupyter notebook (deepjavalibrary#1002) Change-Id: I1889aa93d2002e6ce02c740d2d1d3517bf586760 commit 8286930 Author: Frank Liu <frankfliu2000@gmail.com> Date: Tue Jun 8 15:29:27 2021 -0700 [tensorflow] fix optOption usage document (deepjavalibrary#1001) Change-Id: Ie044839cf082d63010a5c26d3f2f8833447919c6 commit a26f5b2 Author: Abd-El-Aziz Zayed <48853777+AzizZayed@users.noreply.github.com> Date: Tue Jun 8 15:29:10 2021 -0700 Updated PyTorch Docs (deepjavalibrary#1000) * Added auto softmax metadata for action_recognition * Update PyTorch Docs commit e6890f9 Author: Lanking <qingla@amazon.com> Date: Mon Jun 7 18:25:19 2021 -0700 upgrade xgboost (deepjavalibrary#993) commit a0dcf3a Author: Lanking <qingla@amazon.com> Date: Mon Jun 7 18:25:12 2021 -0700 bump up onnx runtime version (deepjavalibrary#992)
Lokiiiiii
pushed a commit
to Lokiiiiii/djl
that referenced
this pull request
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I19e77cf5a8282bea901434041806eb102549ec0f
Description
Brief description of what this PR is about