Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPE bug in block.toString() function #1076

Merged
merged 1 commit into from
Jul 6, 2021

Conversation

frankfliu
Copy link
Contributor

Change-Id: I2aa8bc6c8d36d01cc00c02778907b040d782330c

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

Change-Id: I2aa8bc6c8d36d01cc00c02778907b040d782330c
@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2021

Codecov Report

Merging #1076 (122c355) into master (7a7f41f) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1076      +/-   ##
============================================
- Coverage     70.05%   70.03%   -0.02%     
+ Complexity     5231     5229       -2     
============================================
  Files           511      511              
  Lines         23339    23341       +2     
  Branches       2492     2493       +1     
============================================
- Hits          16350    16347       -3     
- Misses         5660     5663       +3     
- Partials       1329     1331       +2     
Impacted Files Coverage Δ
api/src/main/java/ai/djl/nn/AbstractBlock.java 64.51% <100.00%> (+0.46%) ⬆️
api/src/main/java/ai/djl/repository/Artifact.java 89.65% <0.00%> (-1.73%) ⬇️
.../main/java/ai/djl/benchmark/AbstractBenchmark.java 91.22% <0.00%> (-1.17%) ⬇️
...mark/src/main/java/ai/djl/benchmark/Arguments.java 78.08% <0.00%> (-0.57%) ⬇️
...n/java/ai/djl/tensorflow/engine/TfSymbolBlock.java 88.65% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a7f41f...122c355. Read the comment docs.

@frankfliu frankfliu merged commit 06f76dd into deepjavalibrary:master Jul 6, 2021
@frankfliu frankfliu deleted the npe branch July 6, 2021 01:33
Lokiiiiii pushed a commit to Lokiiiiii/djl that referenced this pull request Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants