Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the python version bug in the benchmark workflow files #1530

Merged
merged 1 commit into from
Mar 17, 2022

Conversation

KexinFeng
Copy link
Contributor

Description

There is an error reported from
/.github/workflows/native_jni_s3_pytorch.yml

The problem happens at line 74-75 with the error message:

ERROR: This script does not work on Python 3.6 The minimum supported Python version is 3.7. Please use https://bootstrap.pypa.io/pip/3.6/get-pip.py instead.

This error is reported from the file

'https://bootstrap.pypa.io/get-pip.py'

It is fixed by downloading from the compatible source
curl -O https://bootstrap.pypa.io/pip/3.6/get-pip.py

@KexinFeng KexinFeng changed the title [BUG] Fix the python version bug in the benchmark workflow files Fix the python version bug in the benchmark workflow files Mar 16, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 16, 2022

Codecov Report

Merging #1530 (16585c8) into master (bb5073f) will decrease coverage by 1.36%.
The diff coverage is 49.96%.

@@             Coverage Diff              @@
##             master    #1530      +/-   ##
============================================
- Coverage     72.08%   70.72%   -1.37%     
- Complexity     5126     5351     +225     
============================================
  Files           473      500      +27     
  Lines         21970    23370    +1400     
  Branches       2351     2552     +201     
============================================
+ Hits          15838    16528     +690     
- Misses         4925     5559     +634     
- Partials       1207     1283      +76     
Impacted Files Coverage Δ
api/src/main/java/ai/djl/modality/cv/Image.java 69.23% <ø> (-4.11%) ⬇️
...i/djl/modality/cv/translator/BigGANTranslator.java 21.42% <ø> (-5.24%) ⬇️
...odality/cv/translator/BigGANTranslatorFactory.java 33.33% <0.00%> (+8.33%) ⬆️
...nslator/InstanceSegmentationTranslatorFactory.java 14.28% <0.00%> (-3.90%) ⬇️
.../modality/cv/translator/YoloTranslatorFactory.java 8.33% <0.00%> (-1.67%) ⬇️
...i/djl/modality/cv/translator/YoloV5Translator.java 5.69% <0.00%> (ø)
...odality/cv/translator/YoloV5TranslatorFactory.java 8.33% <0.00%> (-1.67%) ⬇️
...pi/src/main/java/ai/djl/ndarray/BytesSupplier.java 54.54% <0.00%> (-12.13%) ⬇️
...pi/src/main/java/ai/djl/repository/Repository.java 83.33% <ø> (ø)
...l/training/loss/SigmoidBinaryCrossEntropyLoss.java 64.00% <0.00%> (ø)
... and 198 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b364e7c...16585c8. Read the comment docs.

@frankfliu frankfliu merged commit c25ca6c into deepjavalibrary:master Mar 17, 2022
@KexinFeng KexinFeng deleted the dev_workflow_bug branch March 17, 2022 22:56
@KexinFeng KexinFeng restored the dev_workflow_bug branch March 17, 2022 22:56
@KexinFeng KexinFeng deleted the dev_workflow_bug branch March 18, 2022 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants