Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api] Make resource loading compatible with java9 module #1541

Merged
merged 1 commit into from
Mar 23, 2022

Conversation

frankfliu
Copy link
Contributor

Class.getResourceAsStream() can only load resource from the same module.
Use ClassLoader.getResource() to search the module path.

Change-Id: I380044b949e3ce76824382be6c489d45b9fae05a

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

Class.getResourceAsStream() can only load resource from the same module.
Use ClassLoader.getResource() to search the module path.

Change-Id: I380044b949e3ce76824382be6c489d45b9fae05a
@frankfliu frankfliu requested a review from zachgk as a code owner March 23, 2022 05:00
@codecov-commenter
Copy link

Codecov Report

Merging #1541 (0ce5f0e) into master (bb5073f) will decrease coverage by 1.30%.
The diff coverage is 50.60%.

@@             Coverage Diff              @@
##             master    #1541      +/-   ##
============================================
- Coverage     72.08%   70.78%   -1.31%     
- Complexity     5126     5354     +228     
============================================
  Files           473      500      +27     
  Lines         21970    23366    +1396     
  Branches       2351     2541     +190     
============================================
+ Hits          15838    16539     +701     
- Misses         4925     5552     +627     
- Partials       1207     1275      +68     
Impacted Files Coverage Δ
api/src/main/java/ai/djl/modality/cv/Image.java 69.23% <ø> (-4.11%) ⬇️
...i/djl/modality/cv/translator/BigGANTranslator.java 21.42% <ø> (-5.24%) ⬇️
...odality/cv/translator/BigGANTranslatorFactory.java 33.33% <0.00%> (+8.33%) ⬆️
...nslator/InstanceSegmentationTranslatorFactory.java 14.28% <0.00%> (-3.90%) ⬇️
.../modality/cv/translator/YoloTranslatorFactory.java 8.33% <0.00%> (-1.67%) ⬇️
...i/djl/modality/cv/translator/YoloV5Translator.java 5.69% <0.00%> (ø)
...odality/cv/translator/YoloV5TranslatorFactory.java 8.33% <0.00%> (-1.67%) ⬇️
...pi/src/main/java/ai/djl/ndarray/BytesSupplier.java 54.54% <0.00%> (-12.13%) ⬇️
...pi/src/main/java/ai/djl/repository/Repository.java 83.33% <ø> (ø)
...l/training/loss/SigmoidBinaryCrossEntropyLoss.java 64.00% <0.00%> (ø)
... and 207 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e581f38...0ce5f0e. Read the comment docs.

@frankfliu frankfliu merged commit 33c29ed into deepjavalibrary:master Mar 23, 2022
@frankfliu frankfliu deleted the module branch March 23, 2022 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants