Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pytorch] Allows load libtroch from pip installation package #1577

Merged
merged 1 commit into from
Apr 19, 2022

Conversation

frankfliu
Copy link
Contributor

@frankfliu frankfliu commented Apr 16, 2022

Change-Id: Ic87302a880564027bed1f213088baac1ee543d9e

Description

the default PyTorch pip package contains both cpu and gpu native binaries. Currently DJL can only load cpu/gpu only pip package:

pip install torch==1.10.0+cu113 -f https://download.pytorch.org/whl/torch_stable.html
or
pip install torch==1.10.0+cpu -f https://download.pytorch.org/whl/torch_stable.html

This PR allows DJL to load libtorch from default pip package on CPU machine. However load on GPU machine will still fail due to missing libtorch_cuda_cpp.so file in the default pip pacakge.

Change-Id: Ic87302a880564027bed1f213088baac1ee543d9e
@codecov-commenter
Copy link

codecov-commenter commented Apr 16, 2022

Codecov Report

Merging #1577 (168f7b7) into master (bb5073f) will decrease coverage by 1.23%.
The diff coverage is 58.26%.

@@             Coverage Diff              @@
##             master    #1577      +/-   ##
============================================
- Coverage     72.08%   70.85%   -1.24%     
- Complexity     5126     5395     +269     
============================================
  Files           473      503      +30     
  Lines         21970    23597    +1627     
  Branches       2351     2567     +216     
============================================
+ Hits          15838    16719     +881     
- Misses         4925     5598     +673     
- Partials       1207     1280      +73     
Impacted Files Coverage Δ
api/src/main/java/ai/djl/modality/cv/Image.java 69.23% <ø> (-4.11%) ⬇️
...i/djl/modality/cv/translator/BigGANTranslator.java 21.42% <ø> (-5.24%) ⬇️
...odality/cv/translator/BigGANTranslatorFactory.java 33.33% <0.00%> (+8.33%) ⬆️
...nslator/InstanceSegmentationTranslatorFactory.java 14.28% <0.00%> (-3.90%) ⬇️
.../modality/cv/translator/YoloTranslatorFactory.java 8.33% <0.00%> (-1.67%) ⬇️
...i/djl/modality/cv/translator/YoloV5Translator.java 5.69% <0.00%> (ø)
...odality/cv/translator/YoloV5TranslatorFactory.java 8.33% <0.00%> (-1.67%) ⬇️
...pi/src/main/java/ai/djl/ndarray/BytesSupplier.java 54.54% <0.00%> (-12.13%) ⬇️
...ain/java/ai/djl/ndarray/index/dim/NDIndexPick.java 100.00% <ø> (ø)
api/src/main/java/ai/djl/nn/Blocks.java 75.00% <0.00%> (-25.00%) ⬇️
... and 229 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d06682...168f7b7. Read the comment docs.

@lanking520
Copy link
Contributor

Have you tested this set up? Does the jobs hang?

@frankfliu frankfliu merged commit 4f81676 into deepjavalibrary:master Apr 19, 2022
@frankfliu frankfliu deleted the pip branch April 19, 2022 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants