Add rpath fix to Native Publish PyTorch #1639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the install name tool fix to downloading the pytorch native libraries. It also updates the gradle script that runs the publish to run on osx which has the fixer tool instead of osx. It does have a minor breaking aspect as now the publish must be run from osx. I did add an early error in case it is run from a different os.
Codecov Report
@@ Coverage Diff @@
## master #1639 +/- ##
============================================
- Coverage 72.08% 70.89% -1.20%
- Complexity 5126 5436 +310
============================================
Files 473 507 +34
Lines 21970 23769 +1799
Branches 2351 2589 +238
============================================
+ Hits 15838 16850 +1012
- Misses 4925 5629 +704
- Partials 1207 1290 +83
Continue to review full report at Codecov.
|
frankfliu
approved these changes
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the install name tool rpath fix to downloading the pytorch native libraries.
It also updates the gradle script that runs the publish to run on osx which has
the fixer tool instead of osx.
It does have a minor breaking aspect as now the publish must be run from osx. I
did add an early error in case it is run from a different os.