Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in OD TF saved model example #2050

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

siddvenk
Copy link
Contributor

Description

Fixes an issue with the model path in the criteria for this example. Seems like this example has been broken since 51b38b6, which added functionality that resolves to a subdir if only 1 exists under the top level modeldir.

@codecov-commenter
Copy link

Codecov Report

Base: 72.08% // Head: 69.72% // Decreases project coverage by -2.36% ⚠️

Coverage data is based on head (e75577d) compared to base (bb5073f).
Patch coverage: 68.90% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2050      +/-   ##
============================================
- Coverage     72.08%   69.72%   -2.37%     
- Complexity     5126     5979     +853     
============================================
  Files           473      599     +126     
  Lines         21970    26526    +4556     
  Branches       2351     2883     +532     
============================================
+ Hits          15838    18495    +2657     
- Misses         4925     6646    +1721     
- Partials       1207     1385     +178     
Impacted Files Coverage Δ
api/src/main/java/ai/djl/modality/cv/Image.java 69.23% <ø> (-4.11%) ⬇️
...rc/main/java/ai/djl/modality/cv/MultiBoxPrior.java 76.00% <ø> (ø)
...rc/main/java/ai/djl/modality/cv/output/Joints.java 71.42% <ø> (ø)
.../main/java/ai/djl/modality/cv/output/Landmark.java 100.00% <ø> (ø)
...main/java/ai/djl/modality/cv/output/Rectangle.java 72.41% <0.00%> (ø)
...i/djl/modality/cv/translator/BigGANTranslator.java 21.42% <0.00%> (-5.24%) ⬇️
...odality/cv/translator/BigGANTranslatorFactory.java 33.33% <0.00%> (+8.33%) ⬆️
.../cv/translator/InstanceSegmentationTranslator.java 0.00% <0.00%> (-86.59%) ⬇️
...nslator/InstanceSegmentationTranslatorFactory.java 7.14% <0.00%> (-11.04%) ⬇️
.../cv/translator/SemanticSegmentationTranslator.java 0.00% <0.00%> (ø)
... and 512 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lanking520 lanking520 merged commit d306d2f into deepjavalibrary:master Sep 29, 2022
@siddvenk siddvenk deleted the tf-saved-model-example branch September 30, 2022 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants