Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tensorflow] Remove String tensor limitation for model output #2056

Merged
merged 2 commits into from
Oct 2, 2022

Conversation

frankfliu
Copy link
Contributor

Fixes #2053

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

@frankfliu frankfliu requested a review from zachgk as a code owner October 2, 2022 01:06
@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2022

Codecov Report

Base: 72.08% // Head: 69.73% // Decreases project coverage by -2.35% ⚠️

Coverage data is based on head (9adb85f) compared to base (bb5073f).
Patch coverage: 68.95% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2056      +/-   ##
============================================
- Coverage     72.08%   69.73%   -2.36%     
- Complexity     5126     5990     +864     
============================================
  Files           473      600     +127     
  Lines         21970    26570    +4600     
  Branches       2351     2888     +537     
============================================
+ Hits          15838    18529    +2691     
- Misses         4925     6655    +1730     
- Partials       1207     1386     +179     
Impacted Files Coverage Δ
api/src/main/java/ai/djl/modality/cv/Image.java 69.23% <ø> (-4.11%) ⬇️
...rc/main/java/ai/djl/modality/cv/MultiBoxPrior.java 76.00% <ø> (ø)
...rc/main/java/ai/djl/modality/cv/output/Joints.java 71.42% <ø> (ø)
.../main/java/ai/djl/modality/cv/output/Landmark.java 100.00% <ø> (ø)
...main/java/ai/djl/modality/cv/output/Rectangle.java 72.41% <0.00%> (ø)
...i/djl/modality/cv/translator/BigGANTranslator.java 21.42% <0.00%> (-5.24%) ⬇️
...odality/cv/translator/BigGANTranslatorFactory.java 33.33% <0.00%> (+8.33%) ⬆️
.../cv/translator/InstanceSegmentationTranslator.java 0.00% <0.00%> (-86.59%) ⬇️
...nslator/InstanceSegmentationTranslatorFactory.java 7.14% <0.00%> (-11.04%) ⬇️
.../cv/translator/SemanticSegmentationTranslator.java 0.00% <0.00%> (ø)
... and 514 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@frankfliu frankfliu merged commit 603f28d into deepjavalibrary:master Oct 2, 2022
@frankfliu frankfliu deleted the tf branch October 2, 2022 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Facing issues when Tensorflow model involves a String as input/output to serving function
3 participants