made the sites copyright year dyanamic #2188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankfliu
reviewed
Nov 26, 2022
index.html
Outdated
| @@ -225,7 +225,8 @@ <h5 class="grey-text text-lighten-4 an-1 "> | |||
| <div class="footer-copyright"> | |||
| <div class="container swiper-no-swiping"> | |||
| <div> | |||
| Copyright 2019 <a class="blue-text text-lighten-3 text-underLine" | |||
| Copyright <span class="an-1">{{ new Date().getFullYear() }}</span> | |||
There was a problem hiding this comment.
Thank for your contribution.
I think the single year copy right should state the year which the first time it published. I think this should not be dynamic
There was a problem hiding this comment.
what about having something like 2019-current year?
There was a problem hiding this comment.
Ok let me make that change then.
frankfliu
approved these changes
Nov 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the copyright year to be dynamic
Made the copyright year dynamic rather than static,hence the year will be updating itself automatically.