Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memory leak in Pt indexing #2300

Merged
merged 5 commits into from
Jan 6, 2023
Merged

Conversation

KexinFeng
Copy link
Contributor

@KexinFeng KexinFeng commented Jan 6, 2023

Description

A patch to the memory leak issue #2283, #2283, #2289
As pointed out in #2283, the native resources allocated by ai.djl.pytorch.jni.PyTorchLibrary#torchIndexInit was not released. This pr fixes it.

@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2023

Codecov Report

Base: 72.08% // Head: 73.95% // Increases project coverage by +1.86% 🎉

Coverage data is based on head (085dacd) compared to base (bb5073f).
Patch coverage: 74.98% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2300      +/-   ##
============================================
+ Coverage     72.08%   73.95%   +1.86%     
- Complexity     5126     7401    +2275     
============================================
  Files           473      774     +301     
  Lines         21970    39749   +17779     
  Branches       2351     3436    +1085     
============================================
+ Hits          15838    29396   +13558     
- Misses         4925     8780    +3855     
- Partials       1207     1573     +366     
Impacted Files Coverage Δ
api/src/main/java/ai/djl/modality/cv/Image.java 69.23% <ø> (-4.11%) ⬇️
...rc/main/java/ai/djl/modality/cv/MultiBoxPrior.java 76.00% <ø> (ø)
...rc/main/java/ai/djl/modality/cv/output/Joints.java 71.42% <ø> (ø)
.../main/java/ai/djl/modality/cv/output/Landmark.java 100.00% <ø> (ø)
...main/java/ai/djl/modality/cv/output/Rectangle.java 72.41% <0.00%> (ø)
...i/djl/modality/cv/translator/BigGANTranslator.java 21.42% <0.00%> (-5.24%) ⬇️
.../modality/cv/translator/ImageFeatureExtractor.java 0.00% <0.00%> (ø)
.../ai/djl/modality/cv/translator/YoloTranslator.java 27.77% <0.00%> (+18.95%) ⬆️
...ain/java/ai/djl/modality/cv/util/NDImageUtils.java 59.21% <0.00%> (ø)
api/src/main/java/ai/djl/modality/nlp/Decoder.java 63.63% <ø> (ø)
... and 717 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants