Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tokenizers] Make Huggingface tokenizers translator factory serializable #2442

Merged
merged 1 commit into from
Mar 5, 2023

Conversation

xyang16
Copy link
Contributor

@xyang16 xyang16 commented Mar 5, 2023

Description

Brief description of what this PR is about

Make Huggingface tokenizers translator factory serializable

@xyang16 xyang16 requested review from zachgk, frankfliu and a team as code owners March 5, 2023 05:30
@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2023

Codecov Report

Patch coverage: 73.75% and project coverage change: +2.07 🎉

Comparison is base (bb5073f) 72.08% compared to head (4cfd252) 74.16%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2442      +/-   ##
============================================
+ Coverage     72.08%   74.16%   +2.07%     
- Complexity     5126     6801    +1675     
============================================
  Files           473      669     +196     
  Lines         21970    29610    +7640     
  Branches       2351     3058     +707     
============================================
+ Hits          15838    21960    +6122     
- Misses         4925     6163    +1238     
- Partials       1207     1487     +280     
Impacted Files Coverage Δ
api/src/main/java/ai/djl/modality/cv/Image.java 69.23% <ø> (-4.11%) ⬇️
...rc/main/java/ai/djl/modality/cv/MultiBoxPrior.java 76.00% <ø> (ø)
...rc/main/java/ai/djl/modality/cv/output/Joints.java 71.42% <ø> (ø)
.../main/java/ai/djl/modality/cv/output/Landmark.java 100.00% <ø> (ø)
...main/java/ai/djl/modality/cv/output/Rectangle.java 72.41% <0.00%> (ø)
...i/djl/modality/cv/translator/BigGANTranslator.java 21.42% <0.00%> (-5.24%) ⬇️
.../modality/cv/translator/ImageFeatureExtractor.java 0.00% <0.00%> (ø)
.../ai/djl/modality/cv/translator/YoloTranslator.java 27.77% <0.00%> (+18.95%) ⬆️
...ain/java/ai/djl/modality/cv/util/NDImageUtils.java 67.10% <0.00%> (+7.89%) ⬆️
api/src/main/java/ai/djl/modality/nlp/Decoder.java 63.63% <ø> (ø)
... and 635 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@xyang16 xyang16 merged commit 79151ad into deepjavalibrary:master Mar 5, 2023
@xyang16 xyang16 deleted the tokenizer branch May 2, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants