Streaming Predict and streamable BytesSupplier #2470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to replace deepjavalibrary#2447 to add support for an iterable streaming version of predict. It creates a StreamingBlock and a streamingTranslator. Then, both are added as part of a new call on Predictor. In addition, it also adds two new BytesSupplier: a pull based IterableBytesSupplier and a asynchronous Pub-Sub based PublisherBytesSupplier.
frankfliu
approved these changes
Mar 28, 2023
zachgk
added a commit
to zachgk/djl-serving
that referenced
this pull request
Mar 28, 2023
This fixes serving for changes from deepjavalibrary/djl#2470. Some more extensive changes should follow including using the servingPredict and PublisherBytesSupplier. To fix CI, they will be part of a separate PR.
frankfliu
pushed a commit
to deepjavalibrary/djl-serving
that referenced
this pull request
Mar 29, 2023
This fixes serving for changes from deepjavalibrary/djl#2470. Some more extensive changes should follow including using the servingPredict and PublisherBytesSupplier. To fix CI, they will be part of a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to replace #2447 to add support for an iterable streaming version of predict. It creates a StreamingBlock and a streamingTranslator. Then, both are added as part of a new call on Predictor.
In addition, it also adds two new BytesSupplier: a pull based IterableBytesSupplier and a asynchronous Pub-Sub based PublisherBytesSupplier.