Add encode and decode to Input and Output #2502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a full serialization rather than just part of content or properties to the Input and Output. It also requires adding equals and hash to them as well.
frankfliu
reviewed
Apr 4, 2023
|
|
||
| /** {@inheritDoc} * */ | ||
| @Override | ||
| public boolean equals(Object o) { |
There was a problem hiding this comment.
This is too heavy, we either use a id or just use Identity
There was a problem hiding this comment.
I moved it to a separate deepEquals() method. So, we can keep the functionality but mostly use the lighter Object equals
| return false; | ||
| } | ||
| Output output = (Output) o; | ||
| return code == output.code && Objects.equals(message, output.message); |
There was a problem hiding this comment.
We cannot just based on message and code
There was a problem hiding this comment.
It has a check based on super.equals() a few lines above. This is the IntelliJ equals template
frankfliu
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a full serialization rather than just part of content or properties to the Input and Output. It also requires adding equals and hash to them as well.