Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api] Refactor ChunkedBytesSupplier to avoid unecessary convertion #2587

Merged
merged 1 commit into from
May 6, 2023

Conversation

frankfliu
Copy link
Contributor

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

@frankfliu frankfliu requested review from zachgk and a team as code owners May 6, 2023 05:25
@codecov-commenter
Copy link

codecov-commenter commented May 6, 2023

Codecov Report

Patch coverage: 71.78% and project coverage change: +1.50 🎉

Comparison is base (bb5073f) 72.08% compared to head (1733ab3) 73.59%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2587      +/-   ##
============================================
+ Coverage     72.08%   73.59%   +1.50%     
- Complexity     5126     6959    +1833     
============================================
  Files           473      684     +211     
  Lines         21970    30399    +8429     
  Branches       2351     3152     +801     
============================================
+ Hits          15838    22371    +6533     
- Misses         4925     6492    +1567     
- Partials       1207     1536     +329     
Impacted Files Coverage Δ
api/src/main/java/ai/djl/modality/cv/Image.java 69.23% <ø> (-4.11%) ⬇️
...rc/main/java/ai/djl/modality/cv/MultiBoxPrior.java 76.00% <ø> (ø)
.../main/java/ai/djl/modality/cv/output/Landmark.java 100.00% <ø> (ø)
...i/djl/modality/cv/translator/BigGANTranslator.java 21.42% <0.00%> (-5.24%) ⬇️
.../modality/cv/translator/ImageFeatureExtractor.java 0.00% <0.00%> (ø)
.../ai/djl/modality/cv/translator/YoloTranslator.java 27.77% <0.00%> (+18.95%) ⬆️
...ain/java/ai/djl/modality/cv/util/NDImageUtils.java 67.10% <0.00%> (+7.89%) ⬆️
api/src/main/java/ai/djl/modality/nlp/Decoder.java 63.63% <ø> (ø)
api/src/main/java/ai/djl/modality/nlp/Encoder.java 66.66% <ø> (ø)
.../main/java/ai/djl/modality/nlp/EncoderDecoder.java 64.00% <ø> (ø)
... and 228 more

... and 352 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@frankfliu frankfliu merged commit 8b20e4a into deepjavalibrary:master May 6, 2023
@frankfliu frankfliu deleted the chunk branch May 6, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants