[ci] Upgrade spotbugs to 5.0.14

api/src/main/java/ai/djl/modality/cv/transform/RandomFlipLeftRight.java

@@ -16,31 +16,15 @@
 import ai.djl.translate.Transform;
 import ai.djl.util.RandomUtils;
 
-import java.util.Random;
-
 /**
  * A {@link Transform} that randomly flip the input image left to right with a probability of 0.5.
  */
 public class RandomFlipLeftRight implements Transform {
-    Integer seed;
-
-    /** Creates a new instance of {@code RandomFlipLeftRight}. */
-    public RandomFlipLeftRight() {}
-
-    /**
-     * Creates a new instance of {@code RandomFlipLeftRight} with the given seed.
-     *
-     * @param seed the value of the seed
-     */
-    public RandomFlipLeftRight(int seed) {
-        this.seed = seed;
-    }
 
     /** {@inheritDoc} */
     @Override
     public NDArray transform(NDArray array) {
-        Random rnd = (seed != null) ? new Random(seed) : RandomUtils.RANDOM;
-        if (rnd.nextFloat() > 0.5) {
+        if (RandomUtils.nextFloat() > 0.5) {
             array.flip(1);
         }
         return array;

api/src/main/java/ai/djl/modality/cv/transform/RandomFlipTopBottom.java

@@ -16,32 +16,15 @@
 import ai.djl.translate.Transform;
 import ai.djl.util.RandomUtils;
 
-import java.util.Random;
-
 /**
  * A {@link Transform} that randomly flip the input image top to bottom with a probability of 0.5.
  */
 public class RandomFlipTopBottom implements Transform {
 
-    Integer seed;
-
-    /** Creates a new instance of {@code RandomFlipTopBottom}. */
-    public RandomFlipTopBottom() {}
-
-    /**
-     * Creates a new instance of {@code RandomFlipTopBottom} with the given seed.
-     *
-     * @param seed the value of the seed
-     */
-    public RandomFlipTopBottom(int seed) {
-        this.seed = seed;
-    }
-
     /** {@inheritDoc} */
     @Override
     public NDArray transform(NDArray array) {
-        Random rnd = (seed != null) ? new Random(seed) : RandomUtils.RANDOM;
-        if (rnd.nextFloat() > 0.5) {
+        if (RandomUtils.nextFloat() > 0.5) {
             array.flip(0);
         }
         return array;

api/src/main/java/ai/djl/training/dataset/RandomSampler.java

@@ -16,7 +16,6 @@
 
 import java.util.Iterator;
 import java.util.NoSuchElementException;
-import java.util.Random;
 import java.util.stream.LongStream;
 
 /**
@@ -26,19 +25,6 @@
  * <p>{@code RandomSampler} samples the data from [0, dataset.size) randomly.
  */
 public class RandomSampler implements Sampler.SubSampler {
-    private Integer seed;
-
-    /** Creates a new instance of {@code RandomSampler}. */
-    public RandomSampler() {}
-
-    /**
-     * Creates a new instance of {@code RandomSampler} with the given seed.
-     *
-     * @param seed the value of the seed
-     */
-    public RandomSampler(int seed) {
-        this.seed = seed;
-    }
 
     private static void swap(long[] arr, int i, int j) {
         long tmp = arr[i];
@@ -49,23 +35,22 @@ private static void swap(long[] arr, int i, int j) {
     /** {@inheritDoc} */
     @Override
     public Iterator<Long> sample(RandomAccessDataset dataset) {
-        return new Iterate(dataset, seed);
+        return new Iterate(dataset);
     }
 
     static class Iterate implements Iterator<Long> {
 
         private long[] indices;
         private long current;
 
-        Iterate(RandomAccessDataset dataset, Integer seed) {
+        Iterate(RandomAccessDataset dataset) {
             long size = dataset.size();
             current = 0;
             indices = LongStream.range(0, size).toArray();
-            Random rnd = (seed != null) ? new Random(seed) : RandomUtils.RANDOM;
             // java array didn't support index greater than max integer
             // so cast to int for now
             for (int i = Math.toIntExact(size) - 1; i > 0; --i) {
-                swap(indices, i, rnd.nextInt(i));
+                swap(indices, i, RandomUtils.nextInt(i));
             }
         }
 

build.gradle

@@ -1,5 +1,5 @@
 plugins {
-    id "com.github.spotbugs" version "4.7.1" apply false
+    id "com.github.spotbugs" version "5.0.14" apply false
 }
 
 defaultTasks 'build'

engines/ml/lightgbm/src/main/java/ai/djl/ml/lightgbm/LgbmEngineProvider.java

@@ -18,7 +18,7 @@
 /** {@code LgbmEngineProvider} is the LightGBM implementation of {@link EngineProvider}. */
 public class LgbmEngineProvider implements EngineProvider {
 
-    private static Engine engine;
+    private static volatile Engine engine; // NOPMD
 
     /** {@inheritDoc} */
     @Override
@@ -34,9 +34,11 @@ public int getEngineRank() {
 
     /** {@inheritDoc} */
     @Override
-    public synchronized Engine getEngine() {
+    public Engine getEngine() {
         if (engine == null) {
-            engine = LgbmEngine.newInstance();
+            synchronized (LgbmEngineProvider.class) {
+                engine = LgbmEngine.newInstance();
+            }
         }
         return engine;
     }

engines/ml/xgboost/src/main/java/ai/djl/ml/xgboost/XgbEngineProvider.java

@@ -18,7 +18,7 @@
 /** {@code XgbEngineProvider} is the XGBoost implementation of {@link EngineProvider}. */
 public class XgbEngineProvider implements EngineProvider {
 
-    private static Engine engine;
+    private static volatile Engine engine; // NOPMD
 
     /** {@inheritDoc} */
     @Override
@@ -34,9 +34,11 @@ public int getEngineRank() {
 
     /** {@inheritDoc} */
     @Override
-    public synchronized Engine getEngine() {
+    public Engine getEngine() {
         if (engine == null) {
-            engine = XgbEngine.newInstance();
+            synchronized (XgbEngineProvider.class) {
+                engine = XgbEngine.newInstance();
+            }
         }
         return engine;
     }

engines/mxnet/mxnet-engine/src/main/java/ai/djl/mxnet/engine/MxEngineProvider.java

@@ -36,7 +36,7 @@ public int getEngineRank() {
     @Override
     public Engine getEngine() {
         if (engine == null) {
-            synchronized (this) {
+            synchronized (MxEngineProvider.class) {
                 engine = MxEngine.newInstance();
             }
         }

engines/mxnet/mxnet-engine/src/main/java/ai/djl/mxnet/engine/MxSymbolBlock.java

@@ -187,7 +187,7 @@ protected NDList forwardInternal(
             boolean training,
             PairList<String, Object> params) {
         if (first) {
-            synchronized (MxSymbolBlock.class) {
+            synchronized (this) {
                 if (first) {
                     // create CachedOp is not thread-safe
                     // add synchronized block to avoid creating multiple CachedOps

engines/onnxruntime/onnxruntime-engine/src/main/java/ai/djl/onnxruntime/engine/OrtEngineProvider.java

@@ -36,7 +36,7 @@ public int getEngineRank() {
     @Override
     public Engine getEngine() {
         if (engine == null) {
-            synchronized (this) {
+            synchronized (OrtEngineProvider.class) {
                 engine = OrtEngine.newInstance();
             }
         }

engines/paddlepaddle/paddlepaddle-engine/src/main/java/ai/djl/paddlepaddle/engine/PpEngineProvider.java

@@ -36,7 +36,7 @@ public int getEngineRank() {
     @Override
     public Engine getEngine() {
         if (engine == null) {
-            synchronized (this) {
+            synchronized (PpEngineProvider.class) {
                 engine = PpEngine.newInstance();
             }
         }

engines/pytorch/pytorch-engine/src/main/java/ai/djl/pytorch/engine/PtEngineProvider.java

@@ -36,7 +36,7 @@ public int getEngineRank() {
     @Override
     public Engine getEngine() {
         if (engine == null) {
-            synchronized (this) {
+            synchronized (PtEngineProvider.class) {
                 engine = PtEngine.newInstance();
             }
         }

engines/pytorch/pytorch-engine/src/main/java/ai/djl/pytorch/engine/PtSymbolBlock.java

@@ -135,7 +135,7 @@ protected NDList forwardInternal(
             JniUtils.setGraphExecutorOptimize(setOptimizer);
         }
         if (first) {
-            synchronized (PtSymbolBlock.class) {
+            synchronized (this) {
                 if (first) {
                     inputDescriptions = new PairList<>();
                     outputDescriptions = new PairList<>();

engines/tensorflow/tensorflow-engine/src/main/java/ai/djl/tensorflow/engine/TfEngineProvider.java

@@ -36,7 +36,7 @@ public int getEngineRank() {
     @Override
     public Engine getEngine() {
         if (engine == null) {
-            synchronized (this) {
+            synchronized (TfEngineProvider.class) {
                 engine = TfEngine.newInstance();
             }
         }

engines/tensorrt/src/main/java/ai/djl/tensorrt/engine/TrtEngineProvider.java

@@ -36,7 +36,7 @@ public int getEngineRank() {
     @Override
     public Engine getEngine() {
         if (engine == null) {
-            synchronized (this) {
+            synchronized (TrtEngineProvider.class) {
                 engine = TrtEngine.newInstance();
             }
         }

engines/tflite/tflite-engine/src/main/java/ai/djl/tflite/engine/TfLiteEngineProvider.java

@@ -36,7 +36,7 @@ public int getEngineRank() {
     @Override
     public Engine getEngine() {
         if (engine == null) {
-            synchronized (this) {
+            synchronized (TfLiteEngineProvider.class) {
                 engine = TfLiteEngine.newInstance();
             }
         }

engines/tflite/tflite-engine/src/main/java/org/tensorflow/lite/Tensor.java

@@ -274,6 +274,8 @@ DataType dataTypeOf(Object o) {
                     return DataType.STRING;
                 }
             }
+        } else {
+            throw new NullPointerException();
         }
         throw new IllegalArgumentException(
                 "DataType error: cannot resolve DataType of " + o.getClass().getName());

extensions/timeseries/src/main/java/ai/djl/timeseries/transform/ExpectedNumInstanceSampler.java

@@ -14,10 +14,10 @@
 package ai.djl.timeseries.transform;
 
 import ai.djl.ndarray.NDArray;
+import ai.djl.util.RandomUtils;
 
 import java.util.ArrayList;
 import java.util.List;
-import java.util.Random;
 
 /**
  * Keeps track of the average time series length and adjusts the probability per time point such
@@ -62,10 +62,9 @@ public List<Integer> call(NDArray ts) {
 
         double prob = numInstances / avgLength;
         List<Integer> indices = new ArrayList<>();
-        Random random = new Random();
         while (indices.isEmpty()) {
             for (int i = 0; i < windowSize; i++) {
-                if (random.nextDouble() < prob) {
+                if (RandomUtils.RANDOM.nextDouble() < prob) {
                     indices.add(i + bound[0]);
                 }
             }

tools/conf/findbugs-exclude.xml

@@ -1,36 +1,16 @@
 <?xml version="1.0" encoding="utf-8"?>
 <FindBugsFilter>
     <Match>
-        <Bug pattern="DM_EXIT,DMI_EMPTY_DB_PASSWORD,DMI_HARDCODED_ABSOLUTE_FILENAME,EI_EXPOSE_REP,EI_EXPOSE_REP2,SF_SWITCH_FALLTHROUGH,NM_CONFUSING"/>
+        <Bug pattern="DM_EXIT,DMI_EMPTY_DB_PASSWORD,DMI_HARDCODED_ABSOLUTE_FILENAME,EI_EXPOSE_REP,EI_EXPOSE_REP2,EI_EXPOSE_STATIC_REP2,MS_EXPOSE_REP,SF_SWITCH_FALLTHROUGH,NM_CONFUSING"/>
     </Match>
     <!-- low priority issues-->
     <Match>
         <Bug pattern="DM_CONVERT_CASE,SE_TRANSIENT_FIELD_NOT_RESTORED,UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR,BC_UNCONFIRMED_CAST_OF_RETURN_VALUE"/>
     </Match>
     <Match>
-        <Bug pattern="PZLA_PREFER_ZERO_LENGTH_ARRAYS,DB_DUPLICATE_SWITCH_CLAUSES,BC_UNCONFIRMED_CAST,URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD"/>
+        <Bug pattern="PZLA_PREFER_ZERO_LENGTH_ARRAYS,DB_DUPLICATE_SWITCH_CLAUSES,BC_UNCONFIRMED_CAST,URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD,URF_UNREAD_FIELD"/>
     </Match>
-
-    <!-- wildcard suppression -->
     <Match>
-        <Class name="~ai\.djl\.mxnet\.jnarator\.parser\..*"/>
-    </Match>
-    <Match>
-        <Class name="~org\.tensorflow\.lite\..*"/>
-    </Match>
-    <!-- function suppression -->
-    <Match>
-        <Bug pattern="DC_DOUBLECHECK"/>
-        <Class name="~ai\.djl\.mxnet\.engine\.MxSymbolBlock"/>
-        <Method name="forwardInternal"/>
-    </Match>
-    <Match>
-        <Bug pattern="DC_DOUBLECHECK"/>
-        <Class name="~ai\.djl\.pytorch\.engine\.PtSymbolBlock"/>
-        <Method name="forwardInternal"/>
-    </Match>
-    <Match>
-        <Bug pattern="URF_UNREAD_FIELD"/>
-        <Class name="~ai\.djl\.pytorch\.engine\.PtNDArray"/>
+        <Bug pattern="MS_FINAL_PKGPROTECT,MS_PKGPROTECT,NM_METHOD_NAMING_CONVENTION,SF_SWITCH_NO_DEFAULT,DC_DOUBLECHECK,IS2_INCONSISTENT_SYNC"/>
     </Match>
 </FindBugsFilter>