Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] ci fails looking for v3 reverting to v2 #2604

Merged
merged 1 commit into from
May 15, 2023

Conversation

tosterberg
Copy link
Contributor

Description

Android Continuous action is failing due to being unable to find v3 of gradle/gradle-build-action, reverting to gradle/gradle-build-action@v2, referencing https://github.com/gradle/gradle-build-action it looks like latest release is still v2, so we will monitor

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

@tosterberg tosterberg requested review from zachgk, frankfliu and a team as code owners May 15, 2023 18:29
@codecov-commenter
Copy link

codecov-commenter commented May 15, 2023

Codecov Report

Patch coverage: 71.75% and project coverage change: +1.52 🎉

Comparison is base (bb5073f) 72.08% compared to head (34b8ad1) 73.61%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2604      +/-   ##
============================================
+ Coverage     72.08%   73.61%   +1.52%     
- Complexity     5126     6959    +1833     
============================================
  Files           473      684     +211     
  Lines         21970    30396    +8426     
  Branches       2351     3149     +798     
============================================
+ Hits          15838    22377    +6539     
- Misses         4925     6487    +1562     
- Partials       1207     1532     +325     
Impacted Files Coverage Δ
api/src/main/java/ai/djl/modality/cv/Image.java 69.23% <ø> (-4.11%) ⬇️
...rc/main/java/ai/djl/modality/cv/MultiBoxPrior.java 76.00% <ø> (ø)
.../main/java/ai/djl/modality/cv/output/Landmark.java 100.00% <ø> (ø)
...djl/modality/cv/transform/RandomFlipLeftRight.java 25.00% <0.00%> (-25.00%) ⬇️
...djl/modality/cv/transform/RandomFlipTopBottom.java 25.00% <0.00%> (-25.00%) ⬇️
...i/djl/modality/cv/translator/BigGANTranslator.java 21.42% <0.00%> (-5.24%) ⬇️
.../modality/cv/translator/ImageFeatureExtractor.java 0.00% <0.00%> (ø)
.../ai/djl/modality/cv/translator/YoloTranslator.java 27.77% <0.00%> (+18.95%) ⬆️
...ain/java/ai/djl/modality/cv/util/NDImageUtils.java 67.10% <0.00%> (+7.89%) ⬆️
api/src/main/java/ai/djl/modality/nlp/Decoder.java 63.63% <ø> (ø)
... and 228 more

... and 353 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tosterberg tosterberg merged commit 63cb671 into deepjavalibrary:master May 15, 2023
@tosterberg tosterberg deleted the ci_android_build_fix branch May 30, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants