[docs] Update pytorch native JNI development document #2613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachgk
reviewed
May 22, 2023
| cd engines/pytorch/pytorch-native | ||
| ./gradlew cleanJNI compileJNI | ||
|
|
||
| ./gradlew :engines:pytorch:pytorch-jni:clean |
There was a problem hiding this comment.
You may want to have a cd back to djl root before this
There was a problem hiding this comment.
cd is not required, :engine:pytorch:... is absolute path for the gradle task
There was a problem hiding this comment.
It would be cd back. On line 111, you move to the local directory engines/pytorch/pytorch-native to run that command. On 114, you expect it to be from root directory so they would have to cd back to root
zachgk
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Brief description of what this PR is about