Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Fixes flaky early stopping test #2866

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

zachgk
Copy link
Contributor

@zachgk zachgk commented Nov 20, 2023

This changes the test from requiring the early stopping at a particular epoch to ensuring that it stops early due to time constraints. This should help reduce the chances of being flaky due to race conditions.

This changes the test from requiring the early stopping at a particular epoch to
ensuring that it stops early due to time constraints. This should help reduce
the chances of being flaky due to race conditions.
@zachgk zachgk requested review from frankfliu and a team as code owners November 20, 2023 23:12
@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2023

Codecov Report

Attention: 1365 lines in your changes are missing coverage. Please review.

Comparison is base (bb5073f) 72.08% compared to head (6c27157) 72.30%.
Report is 917 commits behind head on master.

Files Patch % Lines
...va/ai/djl/modality/nlp/generate/TextGenerator.java 2.81% 276 Missing ⚠️
.../java/ai/djl/modality/nlp/generate/SeqBatcher.java 0.75% 132 Missing ⚠️
...ity/nlp/generate/ContrastiveSeqBatchScheduler.java 2.97% 98 Missing ⚠️
...i/djl/modality/nlp/generate/SeqBatchScheduler.java 9.83% 55 Missing ⚠️
.../java/ai/djl/modality/cv/BufferedImageFactory.java 40.96% 47 Missing and 2 partials ⚠️
...a/ai/djl/modality/nlp/generate/StepGeneration.java 2.04% 48 Missing ⚠️
api/src/main/java/ai/djl/ndarray/NDArray.java 43.42% 39 Missing and 4 partials ⚠️
...n/java/ai/djl/modality/cv/output/CategoryMask.java 22.00% 39 Missing ⚠️
...i/src/main/java/ai/djl/ndarray/NDArrayAdapter.java 71.21% 31 Missing and 7 partials ⚠️
.../cv/translator/SemanticSegmentationTranslator.java 37.50% 35 Missing ⚠️
... and 76 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2866      +/-   ##
============================================
+ Coverage     72.08%   72.30%   +0.21%     
- Complexity     5126     7163    +2037     
============================================
  Files           473      708     +235     
  Lines         21970    31915    +9945     
  Branches       2351     3314     +963     
============================================
+ Hits          15838    23077    +7239     
- Misses         4925     7260    +2335     
- Partials       1207     1578     +371     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zachgk zachgk merged commit c846786 into deepjavalibrary:master Nov 21, 2023
5 checks passed
@zachgk zachgk deleted the earlyStopTest branch November 21, 2023 18:00
frankfliu pushed a commit that referenced this pull request Apr 26, 2024
This changes the test from requiring the early stopping at a particular epoch to
ensuring that it stops early due to time constraints. This should help reduce
the chances of being flaky due to race conditions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants