Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api] Allows to load .pt or .onnx file from jar url #2955

Merged
merged 1 commit into from
Jan 20, 2024

Conversation

frankfliu
Copy link
Contributor

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

@frankfliu frankfliu requested review from zachgk and a team as code owners January 19, 2024 16:44
@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.29%. Comparing base (bb5073f) to head (4ec3007).
Report is 1304 commits behind head on master.

Files with missing lines Patch % Lines
.../java/ai/djl/repository/RepositoryFactoryImpl.java 50.00% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2955      +/-   ##
============================================
+ Coverage     72.08%   72.29%   +0.20%     
- Complexity     5126     7282    +2156     
============================================
  Files           473      722     +249     
  Lines         21970    32506   +10536     
  Branches       2351     3391    +1040     
============================================
+ Hits          15838    23499    +7661     
- Misses         4925     7386    +2461     
- Partials       1207     1621     +414     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frankfliu frankfliu merged commit 3bcece6 into deepjavalibrary:master Jan 20, 2024
5 checks passed
@frankfliu frankfliu deleted the pt branch January 20, 2024 01:10
@StefanOltmann
Copy link
Contributor

Good change :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants