Fixes cases where the getEngine method in the EngineProvider class returns null when called concurrently. #3005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3005 +/- ##
============================================
- Coverage 72.29% 72.21% -0.09%
+ Complexity 7292 7280 -12
============================================
Files 722 722
Lines 32525 32483 -42
Branches 3395 3388 -7
============================================
- Hits 23515 23458 -57
- Misses 7385 7412 +27
+ Partials 1625 1613 -12 ☔ View full report in Codecov by Sentry. |
…turns null when called concurrently.
This reverts commit 6141c48.
|
DJL 0.25.0 doesn't have this issue. You can use 0.25.0 for the mean time. |
frankfliu
approved these changes
Feb 26, 2024
frankfliu
added a commit
that referenced
this pull request
Apr 26, 2024
…turns null when called concurrently. (#3005) * Fixes cases where the getEngine method in the EngineProvider class returns null when called concurrently. * Revert "Creates DJL manual engine initialization (#2885)" This reverts commit 6141c48. --------- Co-authored-by: 王旭 <wangxu75@meituan.com> Co-authored-by: Frank Liu <frankfliu2000@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When I create models concurrently using the following methods, I always encounter a null pointer exception because of a problem with the Engine.getEngine("PyTorch ") double-check lock. I wonder if the author has any other intention in this way. However, it is necessary for users to deal with outer layer exceptions.
Model localModel = Engine.getEngine("PyTorch").newModel("test", Device.cpu())