Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread-safe FaceDetectionTranslator #3016

Merged

Conversation

StefanOltmann
Copy link
Contributor

In my application, I employed the FaceDetectionTranslator, but encountered an issue with its lack of thread safety. When attempting to process multiple images simultaneously, EngineErrors occurred. After investigation, I identified the root cause as being related to the variables for width and height.

Fortunately, the TranslatorContext's capacity to carry attachments makes resolving this issue relatively straightforward.

@StefanOltmann StefanOltmann requested review from zachgk, frankfliu and a team as code owners March 4, 2024 07:37
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.23%. Comparing base (93123ad) to head (133e592).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3016      +/-   ##
============================================
- Coverage     72.31%   72.23%   -0.08%     
+ Complexity     7290     7287       -3     
============================================
  Files           722      722              
  Lines         32496    32496              
  Branches       3390     3390              
============================================
- Hits          23498    23473      -25     
- Misses         7380     7408      +28     
+ Partials       1618     1615       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frankfliu frankfliu merged commit 97cfc19 into deepjavalibrary:master Mar 4, 2024
5 checks passed
@StefanOltmann StefanOltmann deleted the thread_safe_facedetection branch March 4, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants