support includeTokenTypes in TextEmbeddingBatchTranslator #3032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankfliu
approved these changes
Mar 18, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3032 +/- ##
============================================
- Coverage 72.29% 72.28% -0.02%
+ Complexity 7293 7290 -3
============================================
Files 722 722
Lines 32512 32513 +1
Branches 3396 3396
============================================
- Hits 23506 23501 -5
- Misses 7386 7391 +5
- Partials 1620 1621 +1 ☔ View full report in Codecov by Sentry. |
frankfliu
added a commit
that referenced
this pull request
Apr 26, 2024
* support includeTokenTypes in TextEmbeddingBatchTranslator Co-authored-by: Frank Liu <frankfliu2000@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows embedding models to obtain token_type_ids from encodings in TextEmbeddingBatchTranslator (TextEmbeddingTranslator already supports it).