Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api] Support encode/decode String tensor #3034

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

frankfliu
Copy link
Contributor

Fixes: #3033

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

@frankfliu frankfliu requested review from zachgk and a team as code owners March 19, 2024 05:17
@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 72.31%. Comparing base (b6b8729) to head (7f786dd).
Report is 1 commits behind head on master.

Files Patch % Lines
...src/main/java/ai/djl/pytorch/engine/PtNDArray.java 60.00% 1 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3034      +/-   ##
============================================
+ Coverage     72.29%   72.31%   +0.01%     
- Complexity     7293     7298       +5     
============================================
  Files           722      722              
  Lines         32512    32533      +21     
  Branches       3396     3401       +5     
============================================
+ Hits          23506    23525      +19     
+ Misses         7386     7385       -1     
- Partials       1620     1623       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frankfliu frankfliu merged commit b3b04f5 into deepjavalibrary:master Mar 22, 2024
5 checks passed
@frankfliu frankfliu deleted the nd branch March 22, 2024 19:49
frankfliu added a commit that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SIGSEGV calling NDList.encode()
3 participants