Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependency version #3049

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Upgrade dependency version #3049

merged 1 commit into from
Mar 28, 2024

Conversation

xyang16
Copy link
Contributor

@xyang16 xyang16 commented Mar 28, 2024

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

@xyang16 xyang16 requested review from zachgk, frankfliu and a team as code owners March 28, 2024 17:02
Copy link
Contributor

@frankfliu frankfliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please

gson_version=2.10.1
jna_version=5.13.0
slf4j_version=1.7.36
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep slf4j 1.x

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

ffmpeg_version=6.0-1.5.9
awssdk_version=2.25.17
hadoop_version=3.4.0
javacpp_version=1.5.10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep java cpp 1.5.9, we can upgrade in next release

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

log4j_slf4j_version=2.23.1
awssdk_version=2.25.13
hadoop_version=3.3.6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let upgrade hadoop in next release

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

javacv_version=1.5.9
ffmpeg_version=6.0-1.5.9
javacv_version=1.5.10
ffmpeg_version=6.1.1-1.5.10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are using javacpp 1.5.10 as well, no upgrade for now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.26%. Comparing base (5eb2b9e) to head (f11810d).

❗ Current head f11810d differs from pull request most recent head 09fe8b9. Consider uploading reports for the commit 09fe8b9 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3049      +/-   ##
============================================
- Coverage     72.31%   72.26%   -0.05%     
  Complexity     7296     7296              
============================================
  Files           722      722              
  Lines         32551    32551              
  Branches       3402     3402              
============================================
- Hits          23538    23522      -16     
- Misses         7389     7409      +20     
+ Partials       1624     1620       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xyang16 xyang16 merged commit 2c1e7fa into deepjavalibrary:master Mar 28, 2024
5 checks passed
@xyang16 xyang16 deleted the dep branch April 3, 2024 18:44
frankfliu pushed a commit that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants