Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Update github action runner to macOS x86_64 instance #3144

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

frankfliu
Copy link
Contributor

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

@frankfliu frankfliu requested review from zachgk and a team as code owners April 30, 2024 20:00
@frankfliu frankfliu merged commit 1d3613a into deepjavalibrary:master Apr 30, 2024
5 checks passed
@frankfliu frankfliu deleted the ci branch April 30, 2024 20:35
@justin-octo
Copy link

There is no description on this. The change involves version locking instead of using latest. Also removing macos from the nightly?
Seems a valid explanation of why this is a good idea should be in the description.

@zachgk
Copy link
Contributor

zachgk commented Jun 19, 2024

@justin-octo This PR is intended to retain a number of our engine build scripts and the nightly tensorflow on OSX x86_64 rather than arm, mostly because these scripts were not supposed to be using arm. It was a change on github actions that latest now refers to arm rather than having x86 remain the default. In the future, these scripts may need to be migrated to further expand our osx arm support, especially as all osx support moves to arm. This change fixes them for the moment.

For nightly, this is only removing the tensorflow part of nightly for which we have never supported osx arm. As a temporary measure, we are going to stop testing tf on osx. If we do add the engine support, we will add this back to nightly as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants