[pytorch] Split maven publish into two parts #3273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachgk
approved these changes
Jun 26, 2024
| @@ -7,6 +7,10 @@ on: | |||
| description: 'staging/snapshot, default is snapshot' | |||
| required: true | |||
| default: 'snapshot' | |||
| package_type: | |||
There was a problem hiding this comment.
Rather than making this an input, it might be better to run as a matrix and have both package builds in one run?
There was a problem hiding this comment.
The problem is on sonatype side, in gradle we are publishing each package sequentially, ideally, each package should landed in the same repo or each with its own repo. We don't have control the close the repo for each package. Even we manually run two publish command, it may or may not in the same repo. Currently, I manually publish one, login to sonatype, close the repo and run another publish.
Co-authored-by: Zach Kimberg <zachary@kimberg.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pytorch native jar file become two large, and sonatype auto staging break the artifacts into multiple staging repo and can not close properly.