Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] add dark theme and fixed broken link #3295

Merged
merged 4 commits into from
Jul 3, 2024
Merged

[docs] add dark theme and fixed broken link #3295

merged 4 commits into from
Jul 3, 2024

Conversation

Varun-Dutta
Copy link
Contributor

@Varun-Dutta Varun-Dutta commented Jul 2, 2024 •
edited
Loading

Description

Added

Testing Methodology

  • Verified that all pages in a locally running instance with the new dark theme toggled on match their counterparts on the live website.

@Varun-Dutta Varun-Dutta marked this pull request as ready for review July 2, 2024 23:04
@Varun-Dutta Varun-Dutta requested review from zachgk, frankfliu and a team as code owners July 2, 2024 23:04
@Varun-Dutta Varun-Dutta marked this pull request as draft July 2, 2024 23:33
@Varun-Dutta Varun-Dutta changed the title [docs] add dark theme [docs] add dark theme and fixed broken link Jul 2, 2024
@Varun-Dutta Varun-Dutta marked this pull request as ready for review July 2, 2024 23:36
@frankfliu frankfliu merged commit 7cceb4a into deepjavalibrary:master Jul 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankfliu frankfliu frankfliu approved these changes

@zachgk zachgk Awaiting requested review from zachgk zachgk is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Varun-Dutta @frankfliu