-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rust] Change loging level to debug #3336
Conversation
@@ -167,7 +167,7 @@ private static boolean copyJniLibraryFromClasspath( | |||
Utils.moveQuietly(tmp, dir); | |||
return true; | |||
} catch (IOException e) { | |||
logger.error("Cannot copy jni files", e); | |||
logger.debug("Cannot copy jni files: {}", e.getMessage()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- We should check null for cu122 case at line 162, it will throw and NPE.
- We should keep it as warning at least. IOException should not happen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For cu122, it will not throw NPE. It will throw IOException:
Resource not found in classpath: native/lib/linux-x86_64/cu122/libtokenizers.so
So IOException is expected to happen, then it will proceed to download.
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3336 +/- ##
============================================
- Coverage 72.93% 72.89% -0.05%
Complexity 7328 7328
============================================
Files 668 668
Lines 32415 32443 +28
Branches 3418 3428 +10
============================================
+ Hits 23642 23648 +6
- Misses 7165 7182 +17
- Partials 1608 1613 +5 ☔ View full report in Codecov by Sentry. |
Description
Brief description of what this PR is about