[rust] Load model on given device #3419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankfliu
reviewed
Aug 16, 2024
| @@ -22,7 +22,7 @@ private RustLibrary() {} | |||
|
|
|||
| public static native boolean isCudaAvailable(); | |||
|
|
|||
| public static native long loadModel(String modelPath, int dtype); | |||
| public static native long loadModel(String modelPath, int dtype, String device); | |||
There was a problem hiding this comment.
Why we use String, can we just use device id?
There was a problem hiding this comment.
Then how to distinguish cpu and cuda?
There was a problem hiding this comment.
There was a problem hiding this comment.
public static native long loadModel(String modelPath, int dtype, int deviceType, int deviceId);
frankfliu
reviewed
Aug 16, 2024
| @@ -234,3 +234,21 @@ pub extern "system" fn Java_ai_djl_engine_rust_RustLibrary_runInference<'local>( | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| pub fn as_device(device: &String) -> Result<Device> { | |||
There was a problem hiding this comment.
Can we re-use existing as_device()
There was a problem hiding this comment.
Ok, I have modified the existing as_device() a little bit, please review.
| @@ -22,7 +22,7 @@ private RustLibrary() {} | |||
|
|
|||
| public static native boolean isCudaAvailable(); | |||
|
|
|||
| public static native long loadModel(String modelPath, int dtype); | |||
| public static native long loadModel(String modelPath, int dtype, String device); | |||
There was a problem hiding this comment.
xyang16
force-pushed
the
rust
branch
4 times, most recently
from
5a010fd to
36302fb
Compare
frankfliu
reviewed
Aug 16, 2024
| .get_string(&model_path) | ||
| .expect("Couldn't get java string!") | ||
| .into(); | ||
| let dtype = as_data_type(dtype).unwrap(); |
There was a problem hiding this comment.
Suggested change
| let dtype = as_data_type(dtype).unwrap(); | |
| let dtype = as_data_type(dtype)?; |
frankfliu
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Brief description of what this PR is about