Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api] Adds base64 image support for ImageTranslator #3456

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

frankfliu
Copy link
Contributor

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

@frankfliu frankfliu requested review from zachgk and a team as code owners September 6, 2024 01:24
@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 36.36364% with 21 lines in your changes missing coverage. Please review.

Project coverage is 58.48%. Comparing base (5c418be) to head (adc5632).
Report is 36 commits behind head on master.

Files with missing lines Patch % Lines
...modality/cv/translator/ImageServingTranslator.java 0.00% 19 Missing ⚠️
...cv/translator/wrapper/StringImagePreProcessor.java 60.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

❗ There is a different number of reports uploaded between BASE (5c418be) and HEAD (adc5632). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (5c418be) HEAD (adc5632)
2 1
Additional details and impacted files
@@              Coverage Diff              @@
##             master    #3456       +/-   ##
=============================================
- Coverage     72.57%   58.48%   -14.10%     
+ Complexity     7377     5804     -1573     
=============================================
  Files           669      672        +3     
  Lines         32658    32817      +159     
  Branches       3474     3489       +15     
=============================================
- Hits          23701    19192     -4509     
- Misses         7319    12150     +4831     
+ Partials       1638     1475      -163     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frankfliu frankfliu merged commit 1ff8bc5 into deepjavalibrary:master Sep 6, 2024
5 checks passed
@frankfliu frankfliu deleted the img branch September 6, 2024 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants