Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tokenizers] Use tokenizers from rust.io #3476

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

xyang16
Copy link
Contributor

@xyang16 xyang16 commented Sep 16, 2024

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

@xyang16 xyang16 requested review from zachgk, frankfliu and a team as code owners September 16, 2024 21:42
@siddvenk
Copy link
Contributor

was there a reason we weren't doing this before?

@xyang16
Copy link
Contributor Author

xyang16 commented Sep 16, 2024

I think because tokenizers was not available in rust.io.

@xyang16 xyang16 merged commit bc31aff into deepjavalibrary:master Sep 16, 2024
14 checks passed
@xyang16 xyang16 deleted the tokenizers branch November 11, 2024 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants