Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pytorch] Adds Yolo11 model to model zoo #3516

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

xyang16
Copy link
Contributor

@xyang16 xyang16 commented Nov 12, 2024

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

@xyang16 xyang16 requested review from zachgk and a team as code owners November 12, 2024 16:42

@Test
public void testYolov8Detection() throws ModelException, TranslateException, IOException {
TestRequirements.notGpu();

DetectedObjects result = Yolov8Detection.predict();
DetectedObjects result = YoloDetection.predict();

Assert.assertTrue(result.getNumberOfObjects() >= 1);
Classifications.Classification obj = result.best();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test needs to be updated:

        Assert.assertTrue(result.getClassNames().contains("dog"));

        Classifications.Classification obj = result.best();
        Assert.assertTrue(obj.getProbability() > 0.6);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.37%. Comparing base (b6656ed) to head (e18dd99).
Report is 16 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3516      +/-   ##
============================================
- Coverage     72.52%   72.37%   -0.16%     
- Complexity     7394     7411      +17     
============================================
  Files           672      674       +2     
  Lines         32909    33048     +139     
  Branches       3501     3523      +22     
============================================
+ Hits          23868    23918      +50     
- Misses         7400     7497      +97     
+ Partials       1641     1633       -8     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xyang16 xyang16 merged commit 890d980 into deepjavalibrary:master Nov 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants