Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Model Dowload Buttons #719
Model Dowload Buttons #719
Changes from 4 commits
757e753
3563314
3dc1bf2
89f48c4
a491d98
5ca07f4
eb8d51d
cb352ad
48cf663
28a32ff
c9d28c8
a059417
347eb07
a363db7
9d55e6e
b4a1cc0
a66e168
5aa09a2
f881e4d
a6a2232
a90129e
c6aebe0
8342d44
43e5891
2158e99
f29daf8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BadRequest is a little vague. How do you plan to use this exception? Is it for something like the request could not be understood because it was not in the proper format "malformed"? Could the request be understood, but what it was requesting did not fully constitute a valid request "invalid"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well it was to say if somehow there is an error where a request did not have all of the parameters that are expected in the request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"serving" uses exactly the same exception for the same purpose I guess. please correct me if I am wrong, so this would be constistent to "serving", especially when we move central as plugin into "serving"
+1 from me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, if serving has the same one then we should keep it to prioritize consistency. This refactor could be revisited later once serving and central are merged